[FFmpeg-devel] [RFC/HACK] textrel-free x86_64 fft_mmx.asm
Mon Nov 16 16:53:01 CET 2009
On Tue, Nov 10, 2009 at 04:50:06PM +0100, Reimar D?ffinger wrote:
> it is rather ugly and might affect speed a bit, but it is the only
> remaining textrel in x86_64 FFmpeg with --enable-pic.
> I really wished there was a RIP-relative, register-argument call.
> I'm sure it can be made at least a bit less ugly, this is my first
> attempt at both that kind of thing and yasm.
I know this idea wasn't liked last time around, so I should probably
give at least the reason:
The linker complains (as in warns, but still continues) when linking
with -pie due to these.
I agree it is only a nice-to-have and not of any real importance, on the
other hand the additional code does not seem that bad to me either
(and I suspect it could be improved by someone less clueless, and I
guess making the define uppercase is a good idea and such).
More information about the ffmpeg-devel