[FFmpeg-devel] [PATCH] Is gray8 a paletted format?

Michael Niedermayer michaelni
Mon Nov 16 01:07:09 CET 2009

On Sun, Nov 15, 2009 at 11:36:03PM +0100, Stefano Sabatini wrote:
> Hi all,
> I see that in imgconvert.c gray8 is treated like a paletted format:
> check for example ff_set_systematic_pal() and ff_fill_pointer(), where
> it is allocated space for its palette.
> If gray8 can be considered a paletted format, then I suggest to apply
> the attached patch, updating both the pixdesc array and the lsws
> macro.
> Regards.
> -- 
> FFmpeg = Fundamental and Fantastic Most Porno Erudite Gadget

>  libavutil/pixdesc.c  |    1 +
>  libswscale/swscale.c |    1 +
>  2 files changed, 2 insertions(+)
> d4e555c7f6b51930b736b49221f546314265ec41  gray-is-pal.patch

This is ok in principle but it has some potential to uncover bugs
id like you to make sure that this works before comiting.
Also please make sure by benchmark that this causes no slowdown
and please add an assert in read_line() that makes sure the
paletted code is not used for gray8

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091116/05dd1baa/attachment.pgp>

More information about the ffmpeg-devel mailing list