[FFmpeg-devel] [PATCH] AVHWAccel infrastructure v2 (take 3)

[Michael Niedermayer]

On Fri, Nov 13, 2009 at 04:50:11PM +0100, Gwenole Beauchesne wrote:
> On Mon, 9 Nov 2009, Michael Niedermayer wrote:
>
>> [...]
>>> @@ -2526,6 +2527,14 @@ typedef struct AVCodecContext {
>>>       * - decoding: Set by libavcodec
>>>       */
>>>       enum AVChromaLocation chroma_sample_location;
>>> +
>>> +    /**
>>> +     * Hardware accelerator configuration attributes.
>>> +     * The array is terminated by HWACCEL_ATTR_NONE.
>>> +     * - encoding: unused
>>> +     * - decoding: Set by user
>>> +     */
>>> +    const uintptr_t *hwaccel_attrs;
>>>  } AVCodecContext;
>>>
>>>  /**
>>
>> uintptr_t is an optional type in C
>> and i really have a bad feeling about using it in public API, i bet this
>> will break several compilers
>>
>> and this way of passing information/attributes is very odd and there is
>> no support in AVOptions to deal with that
>> so i really think a int someflags would be better
>
> Do you mean I should use AVOptions directly + add an FF_OPT_TYPE_POINTER? 
> The problem is I don't see any codec using av_get_*() so I don't think that 
> was what you meant or is there another API to access AVOptions?


i mean

+   int my_flags;
 } AVCodecContext;

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091115/0e7d6dc3/attachment.pgp>