[FFmpeg-devel] [FFMPEG] [PATCH] cavs encoder

zhihang wang zhihang.wang
Sat Nov 14 17:25:30 CET 2009

> thank you for working on this patch and providing it here.
> I hope I will find some time soon to review it in more detail.
> From a quick look, I think the biggest problem with the patch
> is the functional duplication between decoder and enoder.
> It seems you copied many variables from the AVSContext to
> the MpegEncContext and functions which already existed in
> the decoder are duplicated, but now using the variables
> from the MpegEncContext instead of the AVSContext.
> I think it should be possible to have all relevant variables
> in the AVSContext and use common functions in more places.
> Whenever some variable from the MpegEncContext is needed,
> for example options set by the user, one can use code
> like
> int foo(AVSContext *h) {
>        MpegEncContext *s = &h->s;
>        if(s->low_delay)
>                ...
> }
> to access those values.
> That would also decrease the size of the patch and make
> reviewing easier for others not so familiar with the code
> base.
> I'm modifying the code following your suggestions to remove the duplicated
Best Regards
zhihang wang

More information about the ffmpeg-devel mailing list