[FFmpeg-devel] [PATCH] extract bit rate calculation into separate function

Stefano Sabatini stefano.sabatini-lala
Sat Nov 14 00:27:03 CET 2009

On date Friday 2009-11-13 23:42:30 +0100, Robert Kr?ger encoded:
> On 13.11.2009, at 19:02, Michael Niedermayer wrote:
>> your most recent mail adds code duplication, the previous patches are
> Hmmm, the code duplication must refer to the fact that my most recent  
> patch only adds the new function without removing the code from the  
> function where I extracted it. That's how I understood Stefano I should 
> do it, i.e. send the one patch with the new function, have it accepted, 
> then send the one eliminating the duplicate code, which I thought I just 
> did. Please tell me what I should do to do it right so that someone who 
> can make that call will accept it.

I'd say, post the patch which adds the new function, the new function
added should be designed without reference to the existing code, so it
should be minimal and it should be correct.

Once this is applied, you can use the new function when it makes
sense, Michael suggested to follow this path:

* change the old code to make it *functionally* equivalent to the code
  used by the new function

* directly use the new function.

This path may sound a little awkward to follow, but believe me there
are reasons for this practice and if you'll continue to post patches
here you'll became quite used to this.

FFmpeg = Funny and Foolish Murdering Pitiless Elegant Governor

More information about the ffmpeg-devel mailing list