[FFmpeg-devel] [PATCH] extract bit rate calculation into separate function

[Michael Niedermayer]

On Fri, Nov 13, 2009 at 08:59:16AM +0100, Robert Kr?ger wrote:
>
> On 12.11.2009, at 19:29, Michael Niedermayer wrote:
>
>> On Thu, Nov 12, 2009 at 09:13:58AM +0100, Robert Kr?ger wrote:
>>> Hi,
>>>
>>> On 12.11.2009, at 01:42, Stefano Sabatini wrote:
>>>
>>>> On date Wednesday 2009-11-11 12:41:33 +0100, Robert Kr?ger encoded:
>> [...]
>>>>> +
>>> hmm, I tried not to change the behaviour of the code I extracted as I 
>>> only
>>> wanted to refactor and what you suggest would change the behaviour for
>>> CODEC_TYPE_UNKNOWN ,  CODEC_TYPE_ATTACHMENT and CODEC_TYPE_NB as it would
>>> no longer return 0 but return ctx->bit_rate. If that makes sense, I 
>>> cannot
>>> judge. I'll change it accordingly, if you say it does.
>>
>> you could send 2 pathes
>> first to move the code, second to simplify it
>>
> OK, then consider the first one submitted with my most recent email.

your most recent mail adds code duplication, the previous patches are
mangled with line breaks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091113/9a1dc862/attachment.pgp>