[FFmpeg-devel] [FFMPEG] [PATCH] cavs encoder

Diego Biurrun diego
Fri Nov 13 19:02:07 CET 2009

Please don't top-post.

On Sat, Nov 14, 2009 at 01:43:07AM +0800, zhihang wang wrote:
> This attachment is a new version of the cavs encoder. I change the code
> mainly according to* Diego's comments*. I rearrange the main part of the
> patch, cavsenc.c, carefully and added the comments for almost every function
> in detail in order to make the review easier.

You patch is still huge, please split it into parts, for example the
changes to the common code and the decoder first, later the actual
encoder.  This will make review much easier and speed up the acceptance
of this patch.

A few more notes about K&R style formatting:

- Indent case and switch at the same level.
- Put a space before { in if statements etc.
- Please be more generous with spaces around operators, for example in
  if conditions, etc.


More information about the ffmpeg-devel mailing list