[FFmpeg-devel] [PATCH] Long-term prediction for ALS

Ronald S. Bultje rsbultje
Thu Nov 12 18:17:21 CET 2009


Hi,

2009/11/12 M?ns Rullg?rd <mans at mansr.com>:
> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>> int idx = get_unary(gb, 0, 4) << 2 + get_bits(gb, 2);
>> ltp_gain[2] = ltp_gain_values[idx];
>>
>> Or even:
>>
>> int a = get_unary(gb, 0, 4), b = get_bits(gb, 2);
>> ltp_gain[2] = ltp_gain_values[a][b];
>
> Is that a 1D or 2D array. ?Please try to index arrays as they are
> declared, not in some other random fashion. ?It *DOES* break
> sometimes.

It's declared in this very patch, he could easily make it 2D instead
of 1D (I didn't say it explicitely, but obviously the intention is for
him to make the array 2D then).

Ronald



More information about the ffmpeg-devel mailing list