[FFmpeg-devel] [PATCH] set metadata conv tables at runtime

[Anton Khirnov]

On Thu, Nov 12, 2009 at 09:57:00AM +0100, Michael Niedermayer wrote:
> On Thu, Nov 12, 2009 at 06:34:15AM +0100, Anton Khirnov wrote:
> > On Wed, Nov 11, 2009 at 11:55:53PM +0100, Michael Niedermayer wrote:
> > > 
> > > and where is the incompatibility?
> > > the demuxer surely wont have a problem with having both 3 char and 4 char
> > > in its array, also TYER+TDAT+TDRL dont seem to have anything incompatible
> > > on them.
> > > 
> > yes, the problem would be making a conversion table for all 3 versions.
> > it'd be unnecessarily long 
> 
> I dont see that effect, 3 tables or 1 table containing the entries of 3
> should be the same size
> 
yes, but conversion would be slightly slower with big table =p
(btw what is the intented behavior when the table contains duplicate
values?)

anyway, if your point is that this patch is not needed for correct
demuxing of id3v2, you're completely right, i've written it primarily
for files that can contain completely different metadata formats and
muxing.

> 
> IIRC your patch was about demuxing
> 
err no it wasn't. it does exactly what it says in the $subj -- i.e.
changes the api so that coversion tables are set at runtime. this is
done by demuxer when we're demuxing and by av_metadata_conv() when
muxing.

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091112/498d754d/attachment.pgp>