[FFmpeg-devel] [PATCH] get_bits_left()

Michael Niedermayer michaelni
Mon Nov 9 20:41:47 CET 2009

On Mon, Nov 09, 2009 at 07:19:59PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Mon, Nov 09, 2009 at 01:27:25PM -0500, Ronald S. Bultje wrote:
> >> Hi,
> >> 
> >> On Mon, Nov 9, 2009 at 1:21 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > i was always a little against this but as its recurring and a lot of
> >> > people seem to like it, well, patch ok
> >> 
> >> Not knowing any of the previous discussion, could you explain why?
> >> Maybe I can adapt my code (or the patch) to better handle your
> >> objections^d^d doubts.
> >
> > you cant really do anything about it i think
> > the reason why i disliked it was API complexity, its one more function
> > people usng get_bits have to know ...
> A good API has functions for what people do often.  Seems this fits
> that description.


people do that often still it isnt a good idea to have these
+ / * are fine.
the situation here is similar
size_in_bits - where_we_are vs. a new function that says what_is_left

nothing wrong with adding it, i just think its borderline in terms of
difficulty in knowing the API vs. code simplification.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091109/4fbf5a02/attachment.pgp>

More information about the ffmpeg-devel mailing list