[FFmpeg-devel] PIC and YASM

[Reimar Döffinger]

On Mon, Nov 09, 2009 at 01:42:24PM +0100, Diego Biurrun wrote:
> On Sun, Nov 08, 2009 at 07:34:35PM +0100, Reimar D?ffinger wrote:
> > On Sun, Nov 08, 2009 at 01:16:39PM -0500, David Conrad wrote:
> > > On Nov 8, 2009, at 9:35 AM, M?ns Rullg?rd wrote:
> > > 
> > > >Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > > >>
> > > >>and the macho64 special-case.
> > > >
> > > >I don't know the story behind that one.
> > > 
> > > Mach-o doesn't support 32-bit absolute relocations on x86_64, only
> > > 64-bit absolute which most instructions don't support.
> > 
> > Well, but since there is no issue with the inline-assembly, that must
> > mean that our inline assembly must be using PIC-relative addressing,
> > which in turn must mean that one of __PIC__ __pic__ or PIC is defined,
> > which in yet another turn means that my suggested patch would
> > detect that system/compiler as using PIC and enabling it properly,
> > no need for special-case hackery.
> 
> Remove the special case and let us find out.

That depends on the check for PIC.
Attached patch would add it and remove all the hacks that I think would
be unnecessary, though they are untested as of now (though I tested a similar
change for OSX/OSX64 for MPlayer).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: confhacks.diff
Type: text/x-diff
Size: 1217 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091109/a6a05d10/attachment.diff>