[FFmpeg-devel] [RFC] Weighted P-frame prediction in libx264...

Michael Niedermayer michaelni
Mon Nov 9 15:11:05 CET 2009

On Mon, Nov 09, 2009 at 03:36:01AM -0800, Jason Garrett-Glaser wrote:
> With weighted P-frame prediction now in x264 and on by default (and
> not exposed in ffmpeg), it is impossible to encode Baseline Profile
> H.264 with ffmpeg.  This is somewhat of a problem.
> Furthermore, the flag for weightb is CODEC_FLAG2_WPRED, which doesn't
> contain a "B", and thus doesn't really distinguish between weightp or
> weightb.
> Should we change it to CODEC_FLAG2_WPREDB and add CODEC_FLAG2_WPREDP,
> renaming the commandline options as well, or what?

as x264 is our only h264 encoder, i guess ill leave it to you how you
want to handle the h264 encoding options.
just keep in mind
* maintaining API/ABI compatibility is preferred
* keeping options generic so other encoders could use them is also

also is a flag for each enough?
i would suspect that a off/guess/full RD would at least be possible
so 2 int variables might be more flexible and future proof

and deprecated API should be put under the appropriate #if VERSION
so it is automatically removed when we bump the major API version


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091109/ffd32eb6/attachment.pgp>

More information about the ffmpeg-devel mailing list