[FFmpeg-devel] [PATCH] Enable pixdesc.c compilation

Michael Niedermayer michaelni
Sat Nov 7 23:44:00 CET 2009

On Sat, Nov 07, 2009 at 10:48:38PM +0100, Stefano Sabatini wrote:
> On date Saturday 2009-11-07 21:14:56 +0100, Michael Niedermayer encoded:
> > On Sat, Nov 07, 2009 at 04:46:53PM +0100, Stefano Sabatini wrote:
> > > On date Saturday 2009-11-07 13:42:50 +0100, Michael Niedermayer encoded:
> > > > On Sat, Nov 07, 2009 at 12:40:29AM +0100, Stefano Sabatini wrote:
> > > > > Hi,
> > > > > 
> > > > > as in patch, I plan to use it for some incoming filter so I need it.
> > > > 
> > > > until the headers are installed and the API made public theres no way you
> > > > can use this code from outside libavutil
> > > 
> > > Strictly speaking, no this isn't required since we can consider it
> > > just a sort of an internal API, and use it from within FFmpeg as it's
> > > done for many other modules.
> > 
> > any use of code outside libx is external to libx.
> > If you dislike this talk with all the distro maintainers they will explain
> > you with a pitchfork why
> OK so we have a problem here, how am I supposed to replace PixFmtInfo
> if I can't access pixdescs from libavcodec?
> I'm even considering to move pixdesc back to libavcodec, then move it
> again when PixFmtInfo will be removed.

You can move it around as much as you like, it needs to be reviewed and iam
not the right person for it because i wrote it.

as i said, look at the API, think about it, review it
is it understandable?
is it simple?
think about possible uses
does it fullfill them?
can it be extended? (obviously this is only relevant to real extensions
not abstracted "i have no clue why we would want to do X but we cant so
its a poor API")

As is it is pretty compact space wise and i like it but iam not sure if
this might bite us in terms of extendability.

the problem ATM is no comments from anyone about it. I want to hear something
from someone good or bad before it is made public API.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091107/331c641d/attachment.pgp>

More information about the ffmpeg-devel mailing list