[FFmpeg-devel] [PATCH]Allow MPEG4 VDPAU decoding

[Carl Eugen Hoyos]

Hi!

Michael Niedermayer <michaelni <at> gmx.at> writes:

> > +        if (!last) // FIXME: Does this test make sense?
> > +            last = render; // predict second field from the first
> 
> i dont think this test makes sense, there is no I field + P field in
> mpeg4-asp actually there are no field pictures in there at all ...

Makes sense.
Replaced by "assert(last);"

> > +        if (!render->info.mpeg4.vop_coding_type)
> > +            render->info.mpeg4.vop_coding_type    = 1;
> 
> this looks unneeded as well

Removed.
(How did you know?)

> > +        if (CONFIG_MPEG4_VDPAU_DECODER && (s->avctx->codec->capabilities &
> > CODEC_CAP_HWACCEL_VDPAU))
> > +            avctx->codec->pix_fmts = (enum PixelFormat[])
> > {PIX_FMT_VDPAU_MPEG4, PIX_FMT_NONE};
> >          break;
> 
> you cant do that, avctx->codec is shared amongth all instances of mpeg4
> decoders

Could you suggest how to do it?

Thank you for the review, Carl Eugen