[FFmpeg-devel] [PATCH] add ff_init_ff_cos_tabs function, fix rdft with non-hardcoded tables

Michael Niedermayer michaelni
Thu Nov 5 17:11:56 CET 2009

On Wed, Nov 04, 2009 at 06:45:46PM +0100, Reimar D?ffinger wrote:
> Hello,
> this patch adds a ff_init_ff_cos_tabs to simplify initialization of the
> ff_cos_* tables (referenced by ff_cos_tabs).
> It also fixes rdft again which I broke when I removed the duplicated
> initialization of the cosine tables.
> Compared to just reverting to the old code it still has the advantage
> that always the same code is used for initialization, thus avoiding
> the possibility of slightly different values due to different rounding,
> and in general avoiding code duplication.
> Obviously we do not have a QDM2 regression test, which is part of the
> reason why this bug stayed so long, I guess this depends on the 1-off
> method for FATE?

>  dsputil.h |    6 ++++++
>  fft.c     |   24 +++++++++++++++---------
>  rdft.c    |    1 +
>  3 files changed, 22 insertions(+), 9 deletions(-)
> 40f67a7e3fc123da2868edc20c5401287701bf11  costabinit.diff

probably ok


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091105/b4c31e27/attachment.pgp>

More information about the ffmpeg-devel mailing list