[FFmpeg-devel] [PATCH] Make avfilter_get_video_buffer() use default_get_video_buffer if callback not defined

Michael Niedermayer michaelni
Mon Nov 2 22:50:52 CET 2009


On Mon, Nov 02, 2009 at 09:57:08PM +0100, Stefano Sabatini wrote:
> Hi, as recently suggested by Michael after my vf_null.c commit.
> 
> Rationale is that this should simplify the life to lavfi filters
> authors, since they have to explicitely define the get_video_buffer()
> callback if they want the buffer to be requested to the filter following
> in the filterchain.
> 
> This avoids unexpected behaviors if the author doesn't think hard
> about picref allocation, especially when the filter has more than one
> output pad.
> 
> If OK I'll apply the patch splitted, one for each of the modified
> filters and one for avfilter.{h,c}.
> 
> Regards.
> -- 
> FFmpeg = Faboulous and Furious Miracolous Practical Erratic Game

>  avfilter.c  |    3 ---
>  avfilter.h  |    4 ++--
>  vf_format.c |    7 +++++++
>  vf_null.c   |    7 +++++++
>  4 files changed, 16 insertions(+), 5 deletions(-)
> 2cd5ba41c29dd9e0c547cb757aee0cd0836e0341  lavfi-change-get-video-buffer.patch

looks ok


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091102/36950c9c/attachment.pgp>



More information about the ffmpeg-devel mailing list