[FFmpeg-devel] [PATCH] Add slicify filter

Stefano Sabatini stefano.sabatini-lala
Mon Nov 2 21:39:41 CET 2009


On date Sunday 2009-11-01 12:59:12 +0100, Diego Biurrun encoded:
> On Sat, Oct 31, 2009 at 12:26:59AM +0100, Stefano Sabatini wrote:
> > 
> > --- ffmpeg.orig/doc/libavfilter.texi	2009-10-30 12:30:34.000000000 +0100
> > +++ ffmpeg/doc/libavfilter.texi	2009-10-31 00:20:18.000000000 +0100
> > @@ -174,6 +174,20 @@
> >  
> > + at section slicify
> > +
> > +Pass on input video to next video filter as multiple slices.
> 
> This was better before.  You keep placing the fragments of two-part
> verbs together, which you shouldn't.  It's your most glaring mistake and
> you keep repeating it.  I think I have a usable heuristic for you:
> 
> If you would not write a two-part verb together, place them apart, i.e.
> since you would not want to write
> 
>   Passon input video
> 
> you write
> 
>   Pass input video on
> 
> > +The filter accepts the slice height as parameter, if the parameter is
> > +not specified it will use the default value of 16.
> 
> Split that sentence in two.

Fixed.

If there are no other comments I'll apply it tomorrow.

Regards.
-- 
FFmpeg = Frightening Faithful Minimalistic Practical Extravagant God



More information about the ffmpeg-devel mailing list