[FFmpeg-devel] [PATCH] Add -fpre option.

Michael Niedermayer michaelni
Mon Nov 2 12:30:53 CET 2009

On Sun, Nov 01, 2009 at 10:53:37PM -0200, Ramiro Polla wrote:
> Hi,
> msg7668 in issue659 spots another case where the preset files won't
> open a valid path. Also "../" doesn't work for example. Attached patch
> makes it the user's job to pass -fpre to open a preset file and FFmpeg
> will just pass it on to open().

your hack makes it impossible to specify different preset files
for audio and video, that worked before ...
also it complicates the interface

is there a reason why open() is not always tried if all else fails?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091102/1ee90509/attachment.pgp>

More information about the ffmpeg-devel mailing list