[FFmpeg-devel] [PATCH] lls: move the Cholesky decomposition in a separate function

Nicolas George nicolas.george
Sun Nov 1 13:49:17 CET 2009

Le primidi 11 brumaire, an CCXVIII, Michael Niedermayer a ?crit?:
> In what other context would we want to use it?

I intend tu use it for the channels correlation muxer I submitted two days
ago. The rest of the av_solve_lls is really specific to the LPC problem it
is used for, but the Cholesky decomposition itself is very useful (and much
better than the Gau? pivot that I used na?vely).

> Iam not convinced yet that the compile time limit is a problem
> so iam not in favor of replacing it by more complex or less portable code.

I have a very strong distaste for compile-time limits, but I admit it is not
completely rational. It is indeed very unlikely this particular limit will
case problems anytime soon.

Anyway, here is the new corrected version, with your original code in the
function instead of mine and just ASCII in the comments. I left the size of
the arrays in the function arguments to serve as documentation.

(And diff thinks that I moved the header for av_solve_lls instead of a big
piece of its body.)


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-correl-20091101.diff
Type: text/x-diff
Size: 2497 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091101/563d82e3/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091101/563d82e3/attachment.pgp>

More information about the ffmpeg-devel mailing list