[FFmpeg-devel] [PATCH] do not set sample_fmt in lavf
Kostya
kostya.shishkov
Sun Nov 1 08:02:11 CET 2009
On Sat, Oct 31, 2009 at 11:35:10PM -0400, Justin Ruggles wrote:
> Justin Ruggles wrote:
>
> > Hi,
> >
> > The libavcodec documentation for AVCodecContext.sample_fmt says:
> > * - encoding: Set by user.
> > * - decoding: Set by libavcodec.
> >
> > There are 3 demuxers which are setting sample_fmt when they should not
> > (and don't need to). For Smacker Audio, the decoder should be setting
> > it not the demuxer.
> >
> > Patch attached.
> >
> > -Justin
>
> After a 2nd look, I think the Smacker decoder part was wrong. New patch.
Smacker decoder part is wrong - 8-bit samples are decoded as
8-bit in it.
Simply moving that line from demuxer to decoder should be fine though.
More information about the ffmpeg-devel
mailing list