[FFmpeg-devel] [PATCH] lls: move the Cholesky decomposition in a separate function

Nicolas George nicolas.george
Sun Nov 1 00:54:33 CET 2009

Le decadi 10 brumaire, an CCXVIII, Michael Niedermayer a ?crit?:
> The question i have is, why?

I intend to isolate the code that can be useful in other context that just
the LPC computations. The Cholesty decomposition seemed a good place to
start, since it is a very well defined and delimited part of the code.

And the comments were really missing for anyone who wanted to understand
this code.

> Also you completely rewrite the code during the move, making it much more
> complex, harder to read (for me) and bigger (in terms of lines of code)

I rewrote the code to be sure that I really understood it. And in the end, I
chose to submit my version because it did not have the hardcoded limit on
the size of the matrice, although I admit it comes at the cost of harder to
read pointer arithmetic.

I can re-submit the same with exactly your code if you prefer.

Or I can write code using a VLA prototype:

void function(... unsigned n, double m[n][])

if such code is not frowned upon (it is standard C99 but I expect it may
make quite a few compilers chock).

> ahh, and your patch adds non ascii chars, i think there was some kind of
> consensus amongth the ffmpeg devels that non ascii should be limited to
> author names or some translated messages

Ok, I can live without ? and ? in the comments.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091101/d5568462/attachment.pgp>

More information about the ffmpeg-devel mailing list