[FFmpeg-devel] [PATCH] Add support for writing VBR MP3 tags

[Michael Niedermayer]

On Sat, May 30, 2009 at 04:36:15PM +0000, Jai Menon wrote:
> On Sat, May 30, 2009 at 11:00 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, May 30, 2009 at 10:59:21AM +0000, Jai Menon wrote:
> >> On Sat, May 30, 2009 at 10:06 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
[...]
> [...]
> 
> >> Okay, so is this acceptable :
> >>
> >> - mp3_write_header checks if the input stream is vbr and writes an
> >> empty frame after the header
> >
> > how would mp3_write_header() do that?
> 
> Since most encoders put the audio frame with the vbr tag right after
> the id3v2(if it is present), I thought lavf should also store these in
> a "co-located" manner. Is that okay?

i meant "how would mp3_write_header() know that the stream is vbr?" 


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090530/7232d427/attachment.pgp>