[FFmpeg-devel] [PATCH] Add support for writing VBR MP3 tags

[Michael Niedermayer]

On Sat, May 30, 2009 at 06:39:47AM +0000, Jai Menon wrote:
> On Fri, May 29, 2009 at 9:24 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Fri, May 29, 2009 at 07:51:08PM +0000, Jai Menon wrote:
> >> On Fri, May 29, 2009 at 7:22 PM, Jai Menon <jmenon86 at gmail.com> wrote:
> >> > Hi,
> >> >
> >> > As in subject.
> >>
> >> Slightly modified version attached.
> >
> > I dont see how this code could work
> > example, stream copy from mpeg-ps -> .mp3
> 
> Well, that would require a vbr tag writer which constructs the avg.
> bitrate toc. During my experiments, the bitrate changes were not
> visible in the muxer. So this, I think would require more work.

AVPacket.size and duration should provide the rate ...


> Anyway, patch was meant to address one issue for the time being. I
> hope someone can write a more general solution.

i cannot accept the hack in the lame mp3 encoding wraper, its not part
of a correct solution, its just a step in the wrong direction, that is
code we would have to remove later.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090530/c12de5ad/attachment.pgp>