[FFmpeg-devel] [PATCH] Add DPX decoder rev-12

[Jimmy Christensen]

On 2009-05-29 10:18, Kostya wrote:
> On Fri, May 29, 2009 at 08:43:00AM +0200, Jimmy Christensen wrote:
>> On 2009-05-28 12:52, Michael Niedermayer wrote:
>>> On Thu, May 28, 2009 at 07:19:48AM +0200, Jimmy Christensen wrote:
>>>> [...]
>>>>
>>>
>>>> I also forced the avctx->pix_fmt to PIX_FMT_RGB48BE to avoid any portable
>>>> issues and also since this is the only format which is supported by any
>>>> encoders(pnm).
>>>
>>> the output should be PIX_FMT_RGB48
>>
>> The thing is that PIX_FMT_RGB48 becomes PIX_FMT_RGB48BE on big endian
>> systems and PIX_FMT_RGB48LE on little endian systems. Tried to avoid
>> having a if else thing, but probably makes more sense to have the
>> picture frame in the systems native format. Changed it in this patch.
>> The problem now is that without the RGB48 support patch for swscale. The
>> dpx decoder can only be used on big endian systems, since there are no
>> PIX_FMT_RGB48LE supporting encoders. The pnm encoder specifically
>> chooses PIX_FMT_RGB48BE.
>
> Why not help by adding RGB48BE<->RGB48LE<->anything else conversion code
> to swscale? Then any encoder will be able to use decoded DPX source.

I would love to. The RGB48 patch I use right now works quite well and 
looking at the threads about the RGB48 patch it seems to come down to 
some code cleanup to get accepted.

Also I'm just focusing to get DPX support added so it'll get easier to 
help with the RGB48 patch.