[FFmpeg-devel] [PATCH 5/5] ADTS to AudioSpecificConfig bitstream filter

[Benoit Fouet]

On 2009-05-26 22:38, Alex Converse wrote:
> On Fri, May 15, 2009 at 12:03 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>   
>> On Wed, May 13, 2009 at 03:43:09PM -0400, Alex Converse wrote:
>>     
>>> On Wed, May 13, 2009 at 1:51 AM, Alex Converse <alex.converse at gmail.com> wrote:
>>> [...]
>>>       
>>>> fixed
>>>>
>>>> [...]
>>>>
>>>> --Alex
>>>>
>>>>         
>>> 1) New patch to compensate for changes in 0003
>>> 2) Fix spelling
>>>       
>> [...]
>>
>>     
>>> +typedef struct AACBSFContext {
>>> +    int first_frame;
>>>       
>> i think the name of this variable is negated from its semantic meaning
>>
>>     
>
> How about first_frame_done?
>
>   

> +static int aac_adtstoasc_filter(AVBitStreamFilterContext *bsfc,
> +                                AVCodecContext *avctx, const char *args,
> +                                uint8_t  **poutbuf, int *poutbuf_size,
> +                                const uint8_t *buf, int      buf_size,
> +                                int keyframe)
> +{
>
> [...]
>
> +    if (avctx->extradata)
> +        if (!show_bits(&gb, 12) == 0xfff)
> +            return 0;
>

typo

Ben