[FFmpeg-devel] [PATCH] forgotten "enable ppc64" for arch == ppc64

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Mon, May 25, 2009 at 11:11:22PM +0100, M?ns Rullg?rd wrote:
>> > @@ -1808,12 +1808,13 @@
>> >          G5|g5|970|ppc970|PowerPC970|power4*|Power4*)
>> >              add_cflags -mcpu=970 -mpowerpc-gfxopt -mpowerpc64
>> >              warn_altivec disabled PPC970
>> > -            enable ppc64
>> > +            subarch="ppc64"
>> >          ;;
>> >          Cell|CELL|cell)
>> >              add_cflags -mcpu=cell
>> >              warn_altivec disabled Cell
>> > -            enable ppc64 ldbrx
>> > +            subarch="ppc64"
>> > +            enable ldbrx
>> >          ;;
>> 
>> Remove all ppc64 manipulations here.
>
> I have some doubts that's going to really work in general, but patch
> attached.

Why would it not work?  Remember that e.g. a 970 can be run 32-bit
code, so setting ppc64 based on CPU type is wrong.

BTW, what's with that altivec warning message?  The defaults are sane,
so anyone overriding it should be assumed to know what he's doing, and
we don't have such a warning for any other optional CPU feature.

-- 
M?ns Rullg?rd
mans at mansr.com