[FFmpeg-devel] [PATCH] Fix compilation when MMX is disabled

Diego Biurrun diego
Mon May 25 21:04:41 CEST 2009


On Mon, May 25, 2009 at 01:53:31PM -0500, Graham Booker wrote:
> 
> On May 25, 2009, at 12:16 PM, Diego Biurrun wrote:
> 
> >On Mon, May 25, 2009 at 05:03:35PM +0000, Jai Menon wrote:
> >>On Mon, May 25, 2009 at 5:01 PM, Diego Biurrun <diego at biurrun.de>  
> >>wrote:
> >>>On Mon, May 25, 2009 at 04:26:06PM +0000, Jai Menon wrote:
> >>>>On Mon, May 25, 2009 at 4:00 PM, Reimar D?ffinger
> >>>><Reimar.Doeffinger at gmx.de> wrote:
> >>>>>On Mon, May 25, 2009 at 03:12:50PM +0000, Jai Menon wrote:
> >>>>>>As in subject.
> >>>>>
> >>>>>Looks completely wrong, mlpdsp asm does not use MMX.
> >>>>
> >>>>I know it doesn't use MMX, but couldn't find any other way to do  
> >>>>it. I
> >>>>was hoping somebody would suggest the correct way. Should there  
> >>>>be a
> >>>>X86-OBJS ?
> >>>
> >>>OBJS-$(ARCH_X86), similar to what we have for all other ARCHs.
> >>
> >>And how should the CONFIG_MLP_DECODER and CONFIG_TRUEHD_DECODER flags
> >>be checked?
> >
> >With the same trick that we use for e.g. MMX-OBJS and OBJS-$ 
> >(HAVE_MMX).
> 
> I ran into this too.  There doesn't seem to be an X86-OBJS variable,  
> so I created one.  This seems to work for me:

It's half-correct, but mangled by your mailer.

I have already committed a fix.

Diego



More information about the ffmpeg-devel mailing list