[FFmpeg-devel] [RFC][PATCH] return packets for known codecs earlier when codec probing is done

Baptiste Coudurier baptiste.coudurier
Mon May 25 00:03:33 CEST 2009

On 5/23/2009 5:58 PM, Baptiste Coudurier wrote:
> On 5/23/2009 5:49 PM, Michael Niedermayer wrote:
>> On Sat, May 23, 2009 at 03:56:11PM -0700, Baptiste Coudurier wrote:
>>> Hi,
>>> $subject.
>>> I'd like comments on this. I don't really get why we wouldn't return
>>> packets for known codecs. Why do we buffer them ?
>> if we have packets in the buffer we must return them first, before the
>> current packet even if the codec is known, adding the current packet
>> to the buffer is needed as we return an earlier packet first. And cant
>> return 2 at once.
>> But maybe you meant something else?
> Ok.
>>> Problem is that packets for known codecs get buffered but never returned
>>> until codec is sucessfully probed for the unkwnown stream, which might
>>> not even happen.
>> That sounds like a seperat issue, 
>> There could be a size limit at which we turn PROBE in NONE and return
>> stuff ...
> Yes, that's what's needed.

What about this ?

flush_packet_queue needs to flush raw_packet_buffer too.

Do you have samples that need probing I could test against ?

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: stop_codec_probing.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090524/ab561ddb/attachment.asc>

More information about the ffmpeg-devel mailing list