[FFmpeg-devel] [PATCH] wrong AU size in RTP AAC

[Luca Abeni]

Hi,

Yao Peter wrote:
> Hi,
> 
> Just found an bug in rtp_aac.c which use wrong variable when setting the
> AU size field. Patch attached.

Uhm... The current code is obviously wrong, but I suspect
your patch is not correct too. Do you have a testcase for
this bug? Did you test your patch?

I suspect it is not correct because the RFC says:
"When the AU-size is associated with an AU fragment, the AU
size indicates the size of the entire AU and not the size of
the fragment."
And here, "size" is not the size of the AU (it is decreased
in the while loop). I think the attached (untested) patch is
correct...
Comments?


			Thanks,
				Luca
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtp_aac_fix.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090522/cc9b0191/attachment.txt>