[FFmpeg-devel] [PATCH] libavfilter-soc: extend vf_scale.c to make it support colorspace details setting

Stefano Sabatini stefano.sabatini-lala
Fri May 22 00:24:25 CEST 2009


On date Wednesday 2009-05-20 04:02:12 +0200, Michael Niedermayer encoded:
> there are 2 choices
> 1. cleanup your code
> 2. suggest changes to swscale and explain why they are needed to
>    cleanup your code.
> 
> you dont explain what you exactly want to change to what and even less
> so why this would reduce the mess in your patch
>
> Now if i guess what you mean, that is not related to why i rejected your
> patch.
> To oversimplify it a little
> Your patch is rejected because instead of passing the letters from the
> user to swscale you open them.
> Now you seem to suggest to change the content of the letters, how
> could that help cleaning your patch?

Maybe I'm trying to get what you mean, in the direction of code
cleanup, see attached.

Regards.
-- 
FFmpeg = Foolish and Fiendish Mortal Problematic Elitist Gargoyle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scale-add-parse-options-support.patch
Type: text/x-diff
Size: 5744 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090522/bdc4e641/attachment.patch>



More information about the ffmpeg-devel mailing list