[FFmpeg-devel] [PATCH 4/5] Add PCE support to the ADTS muxer.

[Alex Converse]

On Tue, May 19, 2009 at 1:59 PM, Alex Converse <alex.converse at gmail.com> wrote:
> On Tue, May 19, 2009 at 1:40 PM, Diego Biurrun <diego at biurrun.de> wrote:
>>
>> On Tue, May 19, 2009 at 01:36:07PM -0400, Alex Converse wrote:
>> > On Tue, May 19, 2009 at 8:43 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>> > >
>> > > On Wed, May 13, 2009 at 03:42:06PM -0400, Alex Converse wrote:
>> > > > --- a/libavformat/adtsenc.c
>> > > > +++ b/libavformat/adtsenc.c
>> > > > @@ -23,6 +23,7 @@
>> > > > ?#include "libavcodec/get_bits.h"
>> > > > ?#include "libavcodec/put_bits.h"
>> > > > ?#include "libavcodec/internal.h"
>> > > > +#include "libavcodec/mpeg4audio.h"
>> > > > ?#include "avformat.h"
>> > > >
>> > > > [...]
>> > > >
>> > > > + ? ? ? ?adts->pce_size = (ff_copy_pce_data(&pb, &gb) + 3) / 8;
>> > >
>> > > Looks like this file can be compiled without mpeg4audio.c being compiled.
>> > > You probably need to add a Makefile dependency like this:
>> >
>> > But none of the other (de)muxers that require mpeg4audio.c (flvdec.c,
>> > matroska{enc,dec}.c, mov.c) use Makefile dependencies. Should they be
>> > changed as well?
>>
>> Yes.
>>
>
> My apologies, only flvdec is missing it. The rest have it.
>
> --Alex
>

Both are now fixed (r18871).