[FFmpeg-devel] [PATCH] mpeg12: fix non-standard use of "extern inline"

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sat, May 16, 2009 at 07:11:49PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Sat, May 16, 2009 at 02:16:28PM +0100, Mans Rullgard wrote:
>> >> Rename ff_mpeg1_decode_block_intra to mpeg1_decode_block_intra and
>> >> make it static.  Add ff_mpeg1_decode_block_intra as plain extern
>> >> function calling mpeg1_decode_block_intra.
>> >> ---
>> >>  libavcodec/mpeg12.c |   11 +++++++++--
>> >>  libavcodec/mpeg12.h |    2 +-
>> >>  2 files changed, 10 insertions(+), 3 deletions(-)
>> >
>> > hmm, if this fixes a real bug with a real compiler then ok
>> 
>> IBM xlc chokes on the code as-is, and gcc emits warnings.
>
> patch ok then

Applied.

The semantics for extern inline are weird enough, and compiler broken
enough, that I'd rather not use it.

-- 
M?ns Rullg?rd
mans at mansr.com