[FFmpeg-devel] [PATCH] Move MLP's dot product to DSPContext

[Michael Niedermayer]

On Sat, May 16, 2009 at 07:25:27PM +0200, Diego Biurrun wrote:
> On Fri, May 15, 2009 at 02:28:18PM -0300, Ramiro Polla wrote:
> > On Fri, May 15, 2009 at 2:23 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > > On Fri, May 15, 2009 at 10:38:01AM -0300, Ramiro Polla wrote:
> > >> #if ARCH_X86_64
> > >>
> > >> #else /* if ARCH_X86_32 */
> > >>
> > >> #endif /* ARCH_X86_32 */
> > >
> > > Hmmm...
> > >
> > > I find it confusing if the #endif comment differs from the #if condition.
> > 
> > And I find it confusing if the #endif comment relates to the first #if
> > in a sequence.
> > 
> > Should it be:
> > #if ARCH_X86_64
> > #else /* ARCH_X86_32 */
> > #endif /* ARCH_X86_64 */
> > 
> > or:
> > #if ARCH_X86_64
> > #else /* ARCH_X86_64 */
> > #endif /* ARCH_X86_64 */
> > 
> > or just plain:
> > #if ARCH_X86_64
> > #else
> > #endif /* ARCH_X86_64 */
> 
> I prefer the second.

I prefer

#if ARCH_X86_64
#else /* whatever */
#endif /* !ARCH_X86_64 */

or something similar, the key point here is that

#endif /* comment */

comment should tell us when the code above the endif is enabled

#if ARCH_X86_64
[#else]
#endif // ARCH_X86_64

doesnt work because the addition of the #else flips the meaning of the
last block ...


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090516/acb9dd6f/attachment.pgp>