[FFmpeg-devel] [PATCH][RFC] QCP demuxer

[Michael Niedermayer]

On Fri, May 15, 2009 at 03:36:36PM -0700, Kenan Gillet wrote:
> On Fri, May 15, 2009 at 2:16 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Fri, May 15, 2009 at 10:46:12PM +0200, Reimar D?ffinger wrote:
> >> On Fri, May 15, 2009 at 11:21:21AM -0700, Kenan Gillet wrote:
> >> > Any other solution i missed?
> >>
> >> e.g. 8-entry LUT and & 7
> >
> > this does not appear particularly robust in light of a damaged file
> >
> > [...]
> 
> A file with its rate-map-table corrupted but using a fixed rate
> would still be  playable, as one with a corrupted but unused entry.
> So being permissive would be nice, plus, some invalid data would
> be detected later if a corrupted entry is used.
> 

> FIY, I have a sample, a trashed file, with a corrupted rate-map-table,
>  which still played correctly with the solution attached which make it
> round 3.

the probability of a 8 entry table to be corrupted while the rest of the
file is not is rather small, that is compared to "implementation error"
in that sense, are you sure your implementation is correct?
and what makes you think it is corrupted?

[...]

> +            int ret, mode = get_byte(pb);
> +            int pkt_size  = c->fixed_packet_size ? c->fixed_packet_size - 1
> +                                                 : c->rates_per_mode[mode];

this still has the same problem of crashing almost instantly
and being very fragile even if not crashing

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090516/d5c19778/attachment.pgp>