[FFmpeg-devel] [PATCH 3/5] Subroutine to copy an AAC Program Config Element (PCE)

[Alex Converse]

On Wed, May 13, 2009 at 5:21 PM, Robert Swain <robert.swain at gmail.com> wrote:
> Alex Converse wrote:
>>
>> New patch to address Rob's concerns.
>>
>> 1) combines the PCE comment as well
>> 2) moves this to mpeg4audio.[ch] rather than new files
>> 3) fixes a glitch in the matrix (mixdown size)
>
> +#define MAX_PCE_SIZE 304 ///<Maximum size of the data (non-comment) section
> of
> + ? ? ? ? ? ? ? ? ? ? ? ? ///<a PCE including the 3-bit ID_PCE marker and
> the
> + ? ? ? ? ? ? ? ? ? ? ? ? ///<PCE comment
> +
> +int ff_copy_pce_data(PutBitContext *pb, GetBitContext *gb);
> +
>
> Maybe just "Maximum PCE size including 3-bit ID_PCE marker."
>
> Otherwise, looks OK.
>

Applied with new comment

--Alex