[FFmpeg-devel] [PATCH] Fix for inverted sign in ffvorbis audio?output (resubmit)

[Diego Biurrun]

On Wed, May 13, 2009 at 09:39:42AM +0300, Siarhei Siamashka wrote:
> On Tuesday 12 May 2009, Diego Biurrun wrote:
> > On Tue, May 12, 2009 at 02:43:47PM +0000, Carl Eugen Hoyos wrote:
> > > Diego Biurrun <diego <at> biurrun.de> writes:
> > > > > > Reindenting the "for ..." and "alpha = ..." is cosmetics.
> > > > >
> > > > > FFmpeg documentation does not quite agree with you (you are too
> > > > > extreme in this case):
> > > >
> > > > That's MPlayer documentation.
> > >
> > > But FFmpeg documentation says the same:
> > > http://ffmpeg.org/general.html#SEC27
> >
> > Either way, Siarhei did not follow it.
> 
> Quite the opposite. I followed it precisely. What about that '> 5 lines' part
> in "NOTE: If you had to put if(){ .. } over a large (> 5 lines) chunk of code,
> then either do NOT change the indentation of the inner part within (do not
> move it to the right)! or do so in a separate commit"?

You do whatever you want, but if you commit something like this to
FFmpeg, Michael's wrath will be swift and devastating...

Diego