[FFmpeg-devel] [PATCH] Fix for inverted sign in ffvorbis audio?output (resubmit)

[Diego Biurrun]

On Tue, May 12, 2009 at 10:18:57AM +0300, Siarhei Siamashka wrote:
> On Sunday 10 May 2009, Reimar D?ffinger wrote:
> > On Sun, May 10, 2009 at 03:36:13PM +0300, Siarhei Siamashka wrote:
> > But what I meant is that in
> >
> > > -    for(i=0;i<n4;i++) {
> > > -        alpha = 2 * M_PI * (i + 1.0 / 8.0) / n;
> > > -        s->tcos[i] = -cos(alpha);
> > > -        s->tsin[i] = -sin(alpha);
> > > +    if (scale < 0.0) {
> > > +        scale = sqrt(-scale);
> > > +        for(i=0;i<n4;i++) {
> > > +            alpha = 2 * M_PI * (i + 1.0 / 8.0) / n;
> > > +            s->tcos[i] = sin(alpha) * scale;
> > > +            s->tsin[i] = -cos(alpha) * scale;
> > > +        }
> > > +    } else {
> > > +        scale = sqrt(scale);
> > > +        for(i=0;i<n4;i++) {
> > > +            alpha = 2 * M_PI * (i + 1.0 / 8.0) / n;
> > > +            s->tcos[i] = -cos(alpha) * scale;
> > > +            s->tsin[i] = -sin(alpha) * scale;
> > > +        }
> >
> > Reindenting the "for ..." and "alpha = ..." is cosmetics.
> 
> FFmpeg documentation does not quite agree with you (you are too extreme in
> this case):

That's MPlayer documentation.

Just reindent in a separate commit.

Diego