[FFmpeg-devel] [PATCH] Add DPX decoder rev-8

[Jimmy Christensen]

On 2009-05-11 10:57, Diego Biurrun wrote:
> On Mon, May 11, 2009 at 07:59:13AM +0200, Jimmy Christensen wrote:
>> On 2009-05-11 07:42, Diego Biurrun wrote:
>>> On Mon, May 11, 2009 at 07:28:55AM +0200, Jimmy Christensen wrote:
>>>> On 2009-05-11 07:11, Jimmy Christensen wrote:
>>>>>
>>>>> Everything else should be fixed now.
>>>>
>>>> Whoops. Forgot Changelog and documentation.
>>>>
>>>> --- libavcodec/dpx.c	(revision 0)
>>>> +++ libavcodec/dpx.c	(revision 0)
>>>> @@ -0,0 +1,181 @@
>>>> +
>>>> +    /* Check if the files "magic number" is "SDPX" which means it uses
>>>> +     * big endian or XPDS which is for little endian files */
>>>
>>> big-endian, little-endian
>>
>> corrected now, thanks.
>
> No.

Hmmmm.. my mistake. It was fixed in the code I'm looking at here. I 
guess it didn't make the patch. My bad.

Fixed now. I promise! :)

>
> I told you three times already.
>
>>>> +    ptr = p->data[0];
>>>> +    stride = p->linesize[0];
>>>> +
>>>> +    *picture = s->picture;
>>>> +    *data_size = sizeof(AVPicture);
>>>
>>> align
>>
>> Has looked at the code now and I think I got all the alignments correct
>> now. Although I have to admit it's a little hard to see them not there
>> if you are not used to code in K&R. Also as the code was taken from the
>> TGA decoder which is already in ffmpeg it's a bit confusing to get
>> comments on code already in there. Still very new to this, hopefully you
>> will bear with me.
>
> Well, we do have some crufty code in there, never worry ;)

But are the alignments correct in this patch?

>
>> --- Changelog (revision 18796)
>> +++ Changelog (working copy)
>> @@ -16,8 +16,8 @@
>>   - Cook multichannel decoding support
>>   - introduced avlanguage helpers in libavformat
>>   - 8088flex TMV demuxer and decoder
>> +- DPX image decoder
>>
>> -
>>   version 0.5:
>
> Keep the second empty line.  I wonder why you removed it, this was not
> in your previous patches.
>
> Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegDPX-rev8.diff
Type: text/x-patch
Size: 8787 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090511/b680845a/attachment.bin>