[FFmpeg-devel] [PATCH] Add DPX decoder rev-5

[Jimmy Christensen]

On 2009-05-11 07:42, Diego Biurrun wrote:
> On Mon, May 11, 2009 at 07:28:55AM +0200, Jimmy Christensen wrote:
>> On 2009-05-11 07:11, Jimmy Christensen wrote:
>>>
>>> Everything else should be fixed now.
>>
>> Whoops. Forgot Changelog and documentation.
>>
>> --- Changelog	(revision 18736)
>> +++ Changelog	(working copy)
>> @@ -15,6 +15,7 @@
>>   - introduced avlanguage helpers in libavformat
>> +- added DPX image decoder
>
> s/added//

done

>
>> --- libavcodec/dpx.c	(revision 0)
>> +++ libavcodec/dpx.c	(revision 0)
>> @@ -0,0 +1,181 @@
>> +
>> +    /* Check if the files "magic number" is "SDPX" which means it uses
>> +     * big endian or XPDS which is for little endian files */
>
> big-endian, little-endian

corrected now, thanks.

>
>> +    // Jump in extra 744 bytes to end in address 744 + 4 + 4 + 8 = 760 = 0x2f8
>
> Jump an extra ... to end at ...
>
>> +    av_log(NULL, AV_LOG_ERROR, "test\n");
>
> debug cruft?

Yes, thanks :)

>
>> +    ptr = p->data[0];
>> +    stride = p->linesize[0];
>> +
>> +    *picture = s->picture;
>> +    *data_size = sizeof(AVPicture);
>
> align

Has looked at the code now and I think I got all the alignments correct 
now. Although I have to admit it's a little hard to see them not there 
if you are not used to code in K&R. Also as the code was taken from the 
TGA decoder which is already in ffmpeg it's a bit confusing to get 
comments on code already in there. Still very new to this, hopefully you 
will bear with me.

>
>> --- doc/general.texi	(revision 18736)
>> +++ doc/general.texi	(working copy)
>> @@ -240,6 +240,8 @@
>>       @tab Only uncompressed GIFs are generated.
>>   @item BMP          @tab X @tab X
>>       @tab Microsoft BMP image
>> + at item DPX          @tab X @tab X
>> +    @tab Digital Picture Exchange
>
> I did not see you add an encoder.

Whoops, Not good at texinfo. Will perhaps add DPX encoder later :)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegDPX-rev7.diff
Type: text/x-patch
Size: 8789 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090511/61d99618/attachment.bin>