[FFmpeg-devel] [PATCH] Yet another stab at RGB48 support

[Michael Niedermayer]

On Sun, May 10, 2009 at 03:21:23PM +0300, Kostya wrote:
> On Sat, May 09, 2009 at 07:31:20PM +0200, Diego Biurrun wrote:
> > On Sat, May 09, 2009 at 02:28:18PM +0300, Kostya wrote:
> > > $subj
> > 
> > Changelog update is missing.
> > 
> > $nits below
> > 
> [...]
> reformatted, splitted some long lines.
> Since this is diff against libswscale, no Changelog entry (but I
> remember about it).
>  
> [...]
> > > +SwsRGBFunc sws_hires_getRGBFunc(SwsContext *c)
> > > +{
> > > +    const enum PixelFormat srcFormat= c->srcFormat;
> > > +    const enum PixelFormat dstFormat= c->dstFormat;
> > > +    const int srcCbe= srcFormat==PIX_FMT_RGB48BE; /* components big-endian */
> > > +    const int dstCbe= dstFormat==PIX_FMT_RGB48BE;
> > > +    const int srcBpp= (fmt_depth(srcFormat) + 7) >> 3;
> > > +    const int dstBpp= (fmt_depth(dstFormat) + 7) >> 3;
> > > +    const int srcId= (fmt_depth(srcFormat) >> 2) - (srcBpp > 4); /* 1:0, 4:1, 8:2, 15:3, 16:4, 24:6, 32:8, 48:11 */
> > > +    const int dstId= (fmt_depth(dstFormat) >> 2) - (dstBpp > 4);
> > > +    SwsRGBFunc conv = NULL;
> > 
> > extra good karma for spaces around =, same below
> 
> Warum du fixiert da in alle FFmpeg nicht?

erstmal, w?re es "du fixierSt"

zweitens, ist das gesuchte wort "korrigierst" und nicht "fixierst"
fixieren is the meaning of "to fix" in relation to preventing movement,
like some object that is being transportet or a patient on his bed in
a (not so nice) hospital.

drittens, ist die Reihenfolge der worte nicht so ganz richtig

Warum korrigierst du nicht alle in ffmpeg?
ist besser

patch review comes later

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090511/8c776b72/attachment.pgp>