[FFmpeg-devel] [PATCH] [RFC] Bitstream filtering API in libavformat

[Baptiste Coudurier]

Hi Michael,

On 5/5/2009 4:29 AM, Michael Niedermayer wrote:
> [...]
> 
>> +    /**
>> +     * Bitstream needs bitfiltering, this can be set when muxing or demuxing
>> +     * by demuxer or muxer or user
>> +     *
>> +     * Represents a list of successive bitstream filters.
>> +     */
>> +    int disable_bsfiltering;              ///< set to explicitly disable bistream filtering
> 
> ive not tried but i think doxygen would associate both these coments
> to disable_bsfiltering
> 
> also disable_bsfiltering is never written to, thus useless

Well, application can set it. So it's useful I think.

>> [...]
>>
>> +}
>> +
>> +static int ff_stream_bitstream_filters_init(AVFormatContext *s, AVStream *st)
>> +{
> 
> why the split between add & init ?

Good question. I think add & init could be merged. I'll try it.

> also i think we need a way for the user to change these filters from the
> ffmpeg/ffplay command line

Definetely.

Btw do we want the option to apply a bitstream filter before parsing ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org