[FFmpeg-devel] [PATCH] mpegts demuxer gives bogus data after seeking

[Baptiste Coudurier]

Hi,

On 5/5/2009 1:09 AM, Wolfram Gloger wrote:
> Hi,
> 
>> This patch won't work if user uses AVSEEK_FLAG_BYTE which does not call
>> read_seek. Seek detection must be added in mpegts_read_frame, and if
>> seek is detected flush must be done.
> 
> That is indeed true, there is another such case in
> av_estimate_timings_from_pts(), which seeks at the end.
> 
> However, that would incur an url_ftell() for every packet read,
> which I would rather avoid.  OTOH, it may be already there..

I think url_ftell is not a problem.

> It would perhaps better be solved by the ongoing seek-API redesign,
> where _every_ seek should go through a demuxer callback, no?

That may be an idea. It's up to you, if you want to wait :)

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org