[FFmpeg-devel] [PATCH] Add missing pixdescs

[Michael Niedermayer]

On Tue, Mar 31, 2009 at 02:49:51AM +0200, Stefano Sabatini wrote:
> On date Monday 2009-03-30 01:12:51 +0200, Stefano Sabatini encoded:
> > On date Sunday 2009-03-29 23:18:44 +0200, Michael Niedermayer encoded:
> > > On Tue, Mar 24, 2009 at 09:51:26PM +0100, Stefano Sabatini wrote:
> > > > Hi all,
> > > > 
> > > > cosmetics+reorder patch.
> > > > 
> > > > Second patch is unfortunately unreadable, what it does is to resort
> > > > the pixdescs in the same order as the pixfmts, that should ease my
> > > > future work of filling the gaps.
> [...]
> 
> Summary:

> * pixdesc-fix-const.patch
>   Fix write_line() constness.

ok


>   
> * pixdesc-document-read-line.patch
>   Document read_line().

see below


> 
> * pixdesc-readline-cosmetics.patch
>   Various cosmetics.

rejected, i prefer the way it looks now


> 
> * pixdesc-define-step-offset-for-bitstream.patch
>   Change the semantics of the AVComponentDescriptor for bitstream
>   formats.

this does just one thing, make the comment very ambigous

also please send 1 patch per mail
[...]

> Index: libavfilter-soc/ffmpeg/libavcodec/pixdesc.h
> ===================================================================
> --- libavfilter-soc.orig/ffmpeg/libavcodec/pixdesc.h	2009-03-22 22:57:34.000000000 +0100
> +++ libavfilter-soc/ffmpeg/libavcodec/pixdesc.h	2009-03-22 22:57:55.000000000 +0100
> @@ -72,6 +72,18 @@
>   */
>  extern const AVPixFmtDescriptor av_pix_fmt_descriptors[];
>  
> +/**
> + * Reads a line from an image, and writes to \p dst the values of the
> + * pixel format component \p c.
> + *
> + * @param data the array containing the planes of the image

pointers to the planes


> + * @param linesize the array containing the linesize of the image

linesizeS


> + * @param desc the pixel format descriptor for the image
> + * @param x the horizontal coordinate of the first pixel to read
> + * @param y the vertical coordinate of the first pixel to read
> + * @param w the width of the line to read, that is the number of
> + * values to write to \p dst
> + */
>  static inline void read_line(uint16_t *dst, const uint8_t *data[4], const int linesize[4], const AVPixFmtDescriptor *desc, int x, int y, int c, int w)
>  {
>      AVComponentDescriptor comp= desc->comp[c];

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090331/bdd03759/attachment.pgp>