[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

[Luca Abeni]

Hi Ronald,

Ronald S. Bultje wrote:
> Hi Luca,
> 
> On Tue, Mar 24, 2009 at 9:06 AM, Luca Abeni <lucabe72 at email.it> wrote:
>> In this case, the payload will be passed to an ASF demuxer instead
>> of the framer, and the ASF demuxer surely knows how to split an ASF stream
>> in frames...
> 
> Well, yes, but...
> 
> OK, this is ugly, I know.
> 
> MS has different "levels" of "framing"
[...]

Uhm... I am still not convinced, but ok; let's do the frame splitting in 
the rtp demuxer (but please add a comment stating that in this case the 
demuxer has a behaviour different from the other payloads). I'll try to 
clean it up once it is in (I will have to clean up the "ES vs format" 
thing anyway... :).

But I do not think that the ff_rtp_merge_data_packet() function is ok. 
What is needed is a buffer where storing data until a frame is complete. 
And I suspect libavformat already provides this kind of functionality.


				Luca