[FFmpeg-devel] [RFC] Split libswscale's yuv2rgb per dir.

[Måns Rullgård]

Ramiro Polla <ramiro.polla at gmail.com> writes:

> Hi,
>
> On Fri, Mar 20, 2009 at 9:04 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>> On Fri, Mar 20, 2009 at 8:23 PM, Reimar D?ffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
>>> On Fri, Mar 20, 2009 at 11:56:15PM +0100, Michael Niedermayer wrote:
>>>> probably ok
>>>> i suggest to commit the yuv2rgb cleanup before working on sws
>>>
>>> I suggest to wait for at least somewhat working regression tests before
>>> possibly adding more bugs...
>>
>> I'll be away until Tuesday...
>
> If I understood the previous days' e-mails, tests are "working fine" now.
>
> Updated patches attached with a few more changes to the build system
> and updated to latest SVN. Hopefully I haven't forgotten any file in
> this diff.
>
> Tested on:
> x86_64
> x86_64 + mmx
> altivec
> compiled on:
> bfin
> not tested:
> sparc
> mlib
>
> Mans, could you please take a look at the build system parts? (if
> possible without repeating how much you hate swscale again =)

I don't hate swscale as such, only working on it.  Your work here is
much appreciated.

> Ramiro Polla
>
> Index: configure
> ===================================================================
> --- configure	(revision 18178)
> +++ configure	(working copy)
> @@ -2507,6 +2507,11 @@
>          libavutil         \
>          libpostproc       \
>          libswscale        \
> +        libswscale/bfin   \
> +        libswscale/mlib   \
> +        libswscale/ppc    \
> +        libswscale/sparc  \
> +        libswscale/x86    \
>          tests             \
>          tools             \
>          "
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 18178)
> +++ Makefile	(working copy)
> @@ -47,7 +47,8 @@
>  	cp -p $< $@
>  	$(STRIP) $@
>  
> -SUBDIR_VARS := OBJS FFLIBS CLEANFILES DIRS TESTPROGS EXAMPLES
> +SUBDIR_VARS := OBJS FFLIBS CLEANFILES DIRS TESTPROGS EXAMPLES \
> +    ALTIVEC-OBJS-yes MMX-OBJS-yes YASM-OBJS-FFT-yes YASM-OBJS-yes

Drop the -yes suffix from those.  The RESET macro below takes care of
it.  This part can be committed immediately.  Any other similar
variables should also be added here.

>  define RESET
>  $(1) :=
>

-- 
M?ns Rullg?rd
mans at mansr.com