[FFmpeg-devel] [PATCH] Implement av_find_pix_fmt_descriptor* functions

Michael Niedermayer michaelni
Sun Mar 22 02:13:58 CET 2009


On Sun, Mar 22, 2009 at 01:47:17AM +0100, Stefano Sabatini wrote:
> Hi all.
> 
> I'm not sure if is better:
> av_find_pix_fmt_descriptor()
> av_find_pix_fmt_descriptor_by_name()
> 
> which is similar to:
> avcodec_find_decoder()
> avcodec_find_decoder_by_name()
> 
> or
> av_get_pix_fmt_descriptor()
> av_get_pix_fmt_descriptor_by_name()
> 
> which is more similar to:
> avcodec_get_pix_fmt()
> 
> I think "get" is more appropriate for the first case
> (av_get_pix_fmt_descriptor) since we don't have to execute a search
> but just pickup the pixdesc from the internal array, while "find"
> looks more appropriate in the second case.
> 
> Anyway I don't have a strong opinion, so I'd like to hear your
> opinion.
> 
> As for the little test I'll drop it when committing.

what is the point in wraper functions around
array[x]
?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090322/9d7472ef/attachment.pgp>



More information about the ffmpeg-devel mailing list