[FFmpeg-devel] remove libavutil/random.[ch]

[Reimar Döffinger]

On Sat, Mar 21, 2009 at 05:31:55PM +0200, Kostya wrote:
> On Sat, Mar 21, 2009 at 04:10:36PM +0100, Diego Biurrun wrote:
> > On Sat, Mar 21, 2009 at 03:43:09PM +0100, Luca Barbato wrote:
> > > Diego Biurrun wrote:
> > > >libavutil/random.[ch] are deprecated and no longer used anywhere within
> > > >FFmpeg.  I propose deleting them, libavutil is currently in an unstable
> > > >state anyway.
> > > 
> > > Is there something to replace it? rtsp and rtp rfcs have plenty 
> > > references about random number and currently we are using 0 in a bunch 
> > > of places that should use at least consecutive numbers...
> > 
> > Have a look at
> > 
> > libavutil/lfg.h
> > libavutil/random_seed.h
> 
> Why drop it? The problem with it is that it was _default_ random generator.
> Simply renaming it and its functions should be enough.

I think the problem is that it was worse in every aspect than other
generators. Now some specification might require _exactly_ this
generator so it _might_ still make sense to hold on to it, but I am not
sure how much sense it makes.