[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 13A -- alternate)

[Michael Niedermayer]

On Fri, Mar 20, 2009 at 05:48:39PM +0100, Gwenole Beauchesne wrote:
> On Fri, 20 Mar 2009, Michael Niedermayer wrote:
> 
> > [...]
> >> +int ff_vaapi_common_end_frame(AVCodecContext *avctx)
> >> +{
> >
> >> +    MpegEncContext * const s = avctx->priv_data;
> >
> > that is not pretty, in common code
> 
> Do you mean passing an MpegEncContext instead of an AVCodecContext and 
> then use s->avctx instead if that context is needed?
> 
> Or what is not pretty in particular?

that common code assumes avctx->priv_data is a MpegEncContext


[...]
> >> + * AVCodecContext.hwaccel_context.
> >> + */
> >> +struct vaapi_context {
> >> +    void           *display;                ///< Window system dependent data
> >> +    uint32_t        config_id;              ///< Configuration ID
> >> +    uint32_t        context_id;             ///< Context ID (video decode pipeline)
> >> +
> >
> >> +    /* All fields hereunder are private and temporary FFmpeg data used
> >> +       for decoding. */
> >
> > i think this should be written in each doxy for each var, i mean like
> > its done for AVCodecContext. Up there it can be easily missed
> 
> e.g.?
> 
> /**
>   * Context ID (video decode pipeline)
>   *
>   * - encoding: Set by user
>   * - decoding: Set by user
>   */
> uint32_t context_id;
> 
> /**
>   * VAPictureParameterBuffer ID
>   *
>   * - encoding: Set by libavcodec
>   * - decoding: Set by libavcodec
>   */
> VABufferID pic_param_buf_id;
> 
> ? (including de-alignment?... since comments are now "large enough")

yes but there is no encoding (at least not yet) ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090320/b9c89557/attachment.pgp>