[FFmpeg-devel] [PATCH] PCX encoder

[Daniel Verkamp]

On Fri, Mar 20, 2009 at 11:19 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Mar 20, 2009 at 08:39:28AM +0000, Carl Eugen Hoyos wrote:
>> Michael Niedermayer <michaelni <at> gmx.at> writes:
>>
>> > > Reworked... is this what you had in mind?
>> >
>> > yes patch ok
>>
>> Is a regression test needed/useful for this format?
>
> yes
>
> [...]
>
> --
> Michael ? ? GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>

Attached adds a regression test for PCX (using the default rgb24 pixfmt).

Thanks,
-- Daniel Verkamp
-------------- next part --------------
>From 4dca482fffa3ffbbcc577018279c958b712412c2 Mon Sep 17 00:00:00 2001
From: Daniel Verkamp <daniel at drv.nu>
Date: Fri, 20 Mar 2009 12:21:59 -0500
Subject: [PATCH 2/2] Add PCX regression test

---
 Makefile                   |    1 +
 tests/libav.regression.ref |    3 +++
 tests/regression.sh        |    4 ++++
 3 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index c80284e..7be4c3a 100644
--- a/Makefile
+++ b/Makefile
@@ -215,6 +215,7 @@ LAVF_TESTS = $(addprefix regtest-,              \
         tiff                                    \
         sgi                                     \
         jpg                                     \
+        pcx                                     \
         wav                                     \
         alaw                                    \
         mulaw                                   \
diff --git a/tests/libav.regression.ref b/tests/libav.regression.ref
index 017afd3..f0aa8e2 100644
--- a/tests/libav.regression.ref
+++ b/tests/libav.regression.ref
@@ -76,6 +76,9 @@ a61d4116ee455880c9b788b6086a8ffa *./tests/data/b-libav02.tiff
 8dd3739ea6778335f57fb3e2a28c6453 *./tests/data/b-libav02.jpg
 ./tests/data/b-libav%02d.jpg CRC=0x2e3e4535
 31586 ./tests/data/b-libav02.jpg
+574fb8fe0b2fe8cc0b3ded8549c052d4 *./tests/data/b-libav02.pcx
+./tests/data/b-libav%02d.pcx CRC=0x6f775c0d
+363436 ./tests/data/b-libav02.pcx
 b0a8c8063d81921db5d7c8f50a1cc454 *./tests/data/b-libav.wav
 89132 ./tests/data/b-libav.wav
 ./tests/data/b-libav.wav CRC=0x2a09519c
diff --git a/tests/regression.sh b/tests/regression.sh
index bd7bd1c..888860f 100755
--- a/tests/regression.sh
+++ b/tests/regression.sh
@@ -601,6 +601,10 @@ if [ -n "$do_jpg" ] ; then
 do_image_formats jpg "-flags +bitexact -dct fastint -idct simple -pix_fmt yuvj420p" "-f image2"
 fi
 
+if [ -n "$do_pcx" ] ; then
+do_image_formats pcx
+fi
+
 # audio only
 
 if [ -n "$do_wav" ] ; then
-- 
1.6.2