[FFmpeg-devel] [PATCH] don't trust avi riff tag end

Baptiste Coudurier baptiste.coudurier
Thu Mar 19 19:32:32 CET 2009


Hi,

On 3/18/2009 9:39 PM, Michael Niedermayer wrote:
> On Wed, Mar 18, 2009 at 06:35:21PM -0700, Baptiste Coudurier wrote:
>> Hi,
>>
>> $subject,
>>
>> This should fix demuxing avi generated through streaming and read
>> through streaming.
>>
>> In the later case, RIFF tag end is 0, and when reading url_fsize will
>> return 0.
>>
>> Like ffmpeg -i <file> -f avi - | ffmpeg -i -
>>
>> Any problem with this ?
> 
> fsize is used to detect damaged chunks, with INT64_MAX damaged chunks
> are accepted and can lead to skiping of the whole file instead of searching
> for the next valid chunk

I see, would it be ok to only set fsize to INT64_MAX when riff end tag
is not set then ?

Do you see any other alternative ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org




More information about the ffmpeg-devel mailing list